alany9552 opened a new pull request #9240: URL: https://github.com/apache/dubbo/pull/9240
## What is the purpose of the change The purpose of this change is to **fix 2 flaky tests** in the 3.0 version. The following tests are flaky: ``` org.apache.dubbo.common.utils.AnnotationUtilsTest.testGetAllMetaAnnotations org.apache.dubbo.common.utils.AnnotationUtilsTest.testGetMetaAnnotations ``` The tests passes when run regular test command line: ``` mvn -pl dubbo-common test -Dtest=org.apache.dubbo.common.utils.AnnotationUtilsTest#testGetAllMetaAnnotations mvn -pl dubbo-common test -Dtest=org.apache.dubbo.common.utils.AnnotationUtilsTest#testGetMetaAnnotations ``` But it fails when running the NonDex Tools: ``` mvn -pl dubbo-common edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=org.apache.dubbo.common.utils.AnnotationUtilsTest#testGetAllMetaAnnotations mvn -pl dubbo-common edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=org.apache.dubbo.common.utils.AnnotationUtilsTest#testGetMetaAnnotations ``` After checking the testlogs https://github.com/alany9552/flakyreport/blob/master/testgetmetaAnnotations.log, The tests fail due to the **non-deterministic results** produced by `getDeclaredAnnotations()` method. In this method, it calls the `getDeclaredAnnotations()` method imported form the `java.lang.annotation.Annotation` library, which produces a **non-deterministic** results for each run, which fails the original tests testing the order. It seems that it starts to be non-deterministic already when getting the annotations, so it would be better to change the test files, to test if the returned list from `getDeclaredAnnotations()` contains the annotations that we want. After changing it, both tests pass. ## Brief changelog In `testGetAllMetaAnnotations()` and `testGetMetaAnnotations()`, change the testing logic using `HashSet` to see if the results contains the desired value. ## Verifying this change <!-- Follow this checklist to help us incorporate your contribution quickly and easily: --> ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [X] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
