justxuewei commented on a change in pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#discussion_r745695074
##########
File path: metadata/service/exporter/configurable/exporter.go
##########
@@ -69,15 +69,15 @@ func (exporter *MetadataServiceExporter) Export(url
*common.URL) error {
SetGroup(config.GetApplicationConfig().Name).
SetVersion(version).
SetProxyFactoryKey(constant.DefaultKey).
- SetMetadataType(constant.RemoteMetadataStorageType).
+
SetMetadataType(config.GetApplicationConfig().MetadataType).
Build()
exporter.ServiceConfig.Implement(exporter.metadataService)
err := exporter.ServiceConfig.Export()
- logger.Infof("The MetadataService exports urls : %v ",
exporter.ServiceConfig.GetExportedUrls())
+ logger.Infof("[Metadata Service] The MetadataService exports
urls : %v ", exporter.ServiceConfig.GetExportedUrls())
return err
}
- logger.Warnf("The MetadataService has been exported : %v ",
exporter.ServiceConfig.GetExportedUrls())
+ logger.Warnf("[Metadata Service] The MetadataService has been exported
: %v ", exporter.ServiceConfig.GetExportedUrls())
Review comment:
Please remove the useless space at the last.
##########
File path: metadata/service/exporter/configurable/exporter.go
##########
@@ -69,15 +69,15 @@ func (exporter *MetadataServiceExporter) Export(url
*common.URL) error {
SetGroup(config.GetApplicationConfig().Name).
SetVersion(version).
SetProxyFactoryKey(constant.DefaultKey).
- SetMetadataType(constant.RemoteMetadataStorageType).
+
SetMetadataType(config.GetApplicationConfig().MetadataType).
Build()
exporter.ServiceConfig.Implement(exporter.metadataService)
err := exporter.ServiceConfig.Export()
- logger.Infof("The MetadataService exports urls : %v ",
exporter.ServiceConfig.GetExportedUrls())
+ logger.Infof("[Metadata Service] The MetadataService exports
urls : %v ", exporter.ServiceConfig.GetExportedUrls())
Review comment:
Please remove the useless space at the last.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
