AlexStocks commented on a change in pull request #296:
URL: https://github.com/apache/dubbo-go-samples/pull/296#discussion_r748794052
##########
File path: tracing/dubbo/go-server/pkg/user.go
##########
@@ -45,7 +45,7 @@ func (u User) String() string {
)
}
-func (u User) JavaClassName() string {
+func (u *User) JavaClassName() string {
Review comment:
在 go 中，值类型 receiver 的函数，指针类型的变量也可以调用。这里不要改。
##########
File path: tracing/dubbo/go-client/pkg/user.go
##########
@@ -37,7 +37,7 @@ func (u User) String() string {
)
}
-func (User) JavaClassName() string {
+func (u *User) JavaClassName() string {
Review comment:
在 go 中，值类型 receiver 的函数，指针类型的变量也可以调用。这里不要改。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
