zrlw commented on pull request #9273: URL: https://github.com/apache/dubbo/pull/9273#issuecomment-971266864
there are one comment at createExecutorIfAbsent(): ``` // Consumer's executor is sharing globally, key=Integer.MAX_VALUE. Provider's executor is sharing by protocol. Integer portKey = CONSUMER_SIDE.equalsIgnoreCase(url.getParameter(SIDE_KEY)) ? Integer.MAX_VALUE : url.getPort(); ``` two providers might share one executor by url.getPort()? how to remove it from dataStore at destroyAll? add reference count and remove it only when reference count == 0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
