justxuewei commented on a change in pull request #302:
URL: https://github.com/apache/dubbo-go-samples/pull/302#discussion_r755843686
##########
File path: generic/default/go-client/cmd/client.go
##########
@@ -57,7 +56,7 @@ func main() {
//callQueryAll(dubboRefConf)
// generic invocation samples using hessian serialization on Triple
protocol
- tripleRefConf :=
newRefConf("org.apache.dubbo.samples.UserProviderTriple", tpconst.TRIPLE)
+ tripleRefConf := newRefConf("org.apache.dubbo.UserProviderTriple",
tpconst.TRIPLE)
Review comment:
Why remove `.sample` from the code? It may cause something conflicts
with dubbo-java in some cases, cuz they are using `org.apache.dubbo.xxx` as
package name. cc @LaurenceLiZhixin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
