Mulavar commented on a change in pull request #1626:
URL: https://github.com/apache/dubbo-go/pull/1626#discussion_r760021848
##########
File path: config/config_loader_options.go
##########
@@ -155,11 +161,11 @@ func userHomeDir() string {
// checkGenre check Genre
func checkGenre(genre string) error {
- genres := []string{"json", "toml", "yaml", "yml"}
+ genres := []string{"json", "toml", "yaml", "yml", "properties"}
sort.Strings(genres)
idx := sort.SearchStrings(genres, genre)
if genres[idx] != genre {
Review comment:
+1，idx 有没有可能是 -1 的情况？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
