justxuewei commented on a change in pull request #1625:
URL: https://github.com/apache/dubbo-go/pull/1625#discussion_r762712796
##########
File path: protocol/dubbo/impl/hessian.go
##########
@@ -490,6 +490,10 @@ func getArgType(v interface{}) string {
}
switch t.Kind() {
case reflect.Struct:
+ p, ok := v.(hessian.Param)
Review comment:
`Param name` make me confused, I think it's better if it is called
`inherited names` and `interfaces` respectively.
BTW, I think `inherited names` and `interfaces` should return a string array
to fit all inheritance scenarios. For instance, class A inherits from class B,
and class B inherits from class C, so the return value of `inherited names` is
[]string{B, C}.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
