BurningCN commented on a change in pull request #9329:
URL: https://github.com/apache/dubbo/pull/9329#discussion_r762724830
##########
File path:
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ReferenceConfig.java
##########
@@ -241,7 +242,6 @@ public synchronized void destroy() {
ModuleServiceRepository repository =
getScopeModel().getServiceRepository();
repository.unregisterConsumer(consumerModel);
}
- getScopeModel().getConfigManager().removeConfig(this);
Review comment:
The first step of the destroy method will call super.destroy, which is
`ReferenceConfigBase#destroy`, which has already done removeConfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
