[GitHub] [dubbo] wangchengming666 commented on a change in pull request #9348: [3.0] fix #9346 use synchronized linkedlist

[GitBox]

wangchengming666 commented on a change in pull request #9348:
URL: https://github.com/apache/dubbo/pull/9348#discussion_r762732880



##########
File path: 
dubbo-common/src/main/java/org/apache/dubbo/common/config/CompositeConfiguration.java
##########
@@ -21,19 +21,20 @@
 import org.apache.dubbo.common.utils.ArrayUtils;
 
 import java.util.Arrays;
+import java.util.Collections;
 import java.util.LinkedList;
 import java.util.List;
 
 /**
  * This is an abstraction specially customized for the sequence Dubbo 
retrieves properties.
  */
 public class CompositeConfiguration implements Configuration {
-    private Logger logger = 
LoggerFactory.getLogger(CompositeConfiguration.class);
+    private final Logger logger = 
LoggerFactory.getLogger(CompositeConfiguration.class);
 
     /**
      * List holding all the configuration
      */
-    private List<Configuration> configList = new LinkedList<>();
+    private final List<Configuration> configList = 
Collections.synchronizedList(new LinkedList<>());

Review comment:
       @AlbumenJ done, thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org