sanxun0325 commented on a change in pull request #1655:
URL: https://github.com/apache/dubbo-go/pull/1655#discussion_r765534578
##########
File path: remoting/nacos/builder.go
##########
@@ -64,8 +64,17 @@ func GetNacosConfig(url *common.URL)
([]nacosConstant.ServerConfig, nacosConstan
return []nacosConstant.ServerConfig{},
nacosConstant.ClientConfig{},
perrors.WithMessagef(err, "split [%s] ", addr)
}
- port, _ := strconv.Atoi(portStr)
- serverConfigs = append(serverConfigs,
nacosConstant.ServerConfig{IpAddr: ip, Port: uint64(port)})
+ portContextPath := strings.Split(portStr,
constant.PATH_SEPARATOR)
Review comment:
Scheme 可以加,毕竟nacos是支持设置scheme的，我当时感觉可以另起一个pr去增加scheme，所以这个pr里面就没做。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
