zhaoyunxing92 commented on a change in pull request #1656:
URL: https://github.com/apache/dubbo-go/pull/1656#discussion_r766654039
##########
File path: remoting/nacos/builder.go
##########
@@ -69,8 +69,17 @@ func GetNacosConfig(url *common.URL)
([]nacosConstant.ServerConfig, nacosConstan
return []nacosConstant.ServerConfig{},
nacosConstant.ClientConfig{},
perrors.WithMessagef(err, "split [%s] ", addr)
}
- port, _ := strconv.Atoi(portStr)
- serverConfigs = append(serverConfigs,
nacosConstant.ServerConfig{IpAddr: ip, Port: uint64(port)})
+ portContextPath := strings.Split(portStr,
constant.PathSeparator)
Review comment:
这个地方可以考虑下`url.Parse(url)`方法
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
