kylixs commented on a change in pull request #9397:
URL: https://github.com/apache/dubbo/pull/9397#discussion_r768604510
##########
File path:
dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/beans/factory/config/DubboConfigEarlyInitializationPostProcessor.java
##########
@@ -45,27 +42,27 @@
* @see GenericBeanPostProcessorAdapter
* @since 2.7.9
*/
-public class DubboConfigEarlyInitializationPostProcessor extends
GenericBeanPostProcessorAdapter<AbstractConfig>
- implements BeanDefinitionRegistryPostProcessor, PriorityOrdered {
+public class DubboConfigEarlyInitializationPostProcessor extends
GenericBeanPostProcessorAdapter<AbstractConfig> {
private static final Log logger =
LogFactory.getLog(DubboConfigEarlyInitializationPostProcessor.class.getName());
- public static final String BEAN_NAME =
"dubboConfigEarlyInitializationPostProcessor";
+ private static DubboConfigEarlyInitializationPostProcessor SINGLETON;
private DefaultListableBeanFactory beanFactory;
- @Override
- public void postProcessBeanDefinitionRegistry(BeanDefinitionRegistry
registry) throws BeansException {
- this.beanFactory = unwrap(registry);
- initBeanFactory();
+ private
DubboConfigEarlyInitializationPostProcessor(DefaultListableBeanFactory
beanFactory) {
+ this.beanFactory = beanFactory;
}
- @Override
- public void postProcessBeanFactory(ConfigurableListableBeanFactory
beanFactory) throws BeansException {
- if (beanFactory == null) { // try again if
postProcessBeanDefinitionRegistry method does not effect.
- this.beanFactory = unwrap(beanFactory);
- initBeanFactory();
+ public static DubboConfigEarlyInitializationPostProcessor
getSingleton(DefaultListableBeanFactory beanFactory) {
Review comment:
The global instance of DubboConfigEarlyInitializationPostProcessor
holds in DubboConfigEarlyRegistrationPostProcessor is better.
DubboConfigEarlyInitializationPostProcessor just a BeanPostProcessor , it
should not care for how to create and be registered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
