chickenlj commented on a change in pull request #9423:
URL: https://github.com/apache/dubbo/pull/9423#discussion_r770263384
##########
File path:
dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/MetadataInfo.java
##########
@@ -315,27 +315,27 @@ public void setParams(Map<String, String> params) {
}
public String getParameter(String key) {
- if (consumerParams != null) {
+ if (CollectionUtils.isNotEmptyMap(consumerParams)) {
String value = consumerParams.get(key);
- if (value != null) {
+ if (StringUtils.isNotEmpty(value)) {
return value;
}
}
return params.get(key);
}
public String getMethodParameter(String method, String key, String
defaultValue) {
- if (methodParams == null) {
+ if (CollectionUtils.isNotEmptyMap(methodParams)) {
Review comment:
Be careful! The new code checks exactly the opposite condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
