HetaoWang commented on a change in pull request #9451:
URL: https://github.com/apache/dubbo/pull/9451#discussion_r773935926
##########
File path:
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/merger/MergerFactory.java
##########
@@ -49,34 +56,51 @@ public void setScopeModel(ScopeModel scopeModel) {
throw new IllegalArgumentException("returnType is null");
}
- Merger result;
- if (returnType.isArray()) {
- Class type = returnType.getComponentType();
Review comment:
> Another problem is MergerFactory caches merger by return type. But
there may exist more than one merger with same return type, for example
IntFindAnyMerger and IntFindFirstMerger in this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
