tianshuang opened a new pull request #9490: URL: https://github.com/apache/dubbo/pull/9490
In the current implementation, org.apache.dubbo.rpc.protocol.dubbo.DecodeableRpcInvocation#decode(org.apache.dubbo.remoting.Channel, java.io.InputStream) will catch exceptions in readObject, and then only print WARN-level log, If the log level of the provider is ERROR, the error cannot be seen. A common problem is that a NullPointerException be throw when the provider executes business logic. Finally, the consumer gets a NullPointerException, which makes the problem difficult to troubleshoot. For example, when the argument class has only one constructor with parameters, and the constructor parameter is a non-primitive type, Hession will initialize the parameter to be null. If the parameter is used in the constructor to execute business logic, it will trigger related exceptions, such as IllegalArgumentException, but in the current implementation, parameter decoding exceptions will be caught. The provider actually gets an null parameter and executes business logic. In most scenarios, a NullPointerException will be thrown to the consumer. ## What is the purpose of the change Allow the consumer to get the original argument decode exception to facilitate troubleshooting. ## Brief changelog Remove the exception catch and log printing logic when calling readObject, and throw it directly to the outer decode method so that the exception is set into the request instance, and finally sent to the consumer. <!-- Follow this checklist to help us incorporate your contribution quickly and easily: --> ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
