horizonzy commented on pull request #8772: URL: https://github.com/apache/dubbo/pull/8772#issuecomment-1011267588
> `openzipkin/brave` is also affected > > ```java > Map<String, String> attachments = RpcContext.getContext().getAttachments(); > DubboClientRequest clientRequest = new DubboClientRequest(invoker, invocation, attachments); > ``` > > If the user's business code is used, it may be fatal. > > @chickenlj @horizonzy @CrazyHZM @manzhizhen yep, the code has breaking change, It will influence the user who modify the attachments by operate `RpcContext.getContext().getAttachments()`. It's a problem indeed, it shouldn't change original logic. sorry for my careless review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
