wongoo commented on a change in pull request #309:
URL: https://github.com/apache/dubbo-go-hessian2/pull/309#discussion_r786381646



##########
File path: response.go
##########
@@ -204,19 +199,15 @@ func unpackResponseBody(decoder *Decoder, resp 
interface{}) error {
                        }
                }
 
-               // If the return value is nil,
-               // we should consider it normal
-               if rsp == nil {
-                       return nil
-               }
+               response.RspObj = rsp

Review comment:
       @LaurenceLiZhixin @AlexStocks   just assign the decoded object to the 
response,I think this is the biggest change, which should be tested in dubbo-go.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to