BurningCN commented on a change in pull request #9510:
URL: https://github.com/apache/dubbo/pull/9510#discussion_r790394521
##########
File path:
dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/event/listener/ServiceInstancesChangedListener.java
##########
@@ -372,21 +370,20 @@ protected void notifyAddressChanged() {
* Since this listener is shared among interfaces, destroy this listener
only when all interface listener are unsubscribed
*/
public synchronized void destroy() {
- if (!destroyed.get()) {
+ if (!destroyed && CollectionUtils.isEmptyMap(listeners)) {
if (CollectionUtils.isEmptyMap(listeners)) {
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
