zhaoyunxing92 commented on a change in pull request #1633:
URL: https://github.com/apache/dubbo-go/pull/1633#discussion_r800271680
##########
File path: remoting/nacos/builder.go
##########
@@ -39,15 +39,17 @@ import (
"dubbo.apache.org/dubbo-go/v3/config"
)
-const nacosClientName = "nacos-client"
-
// NewNacosConfigClientByUrl read the config from url and build an instance
func NewNacosConfigClientByUrl(url *common.URL)
(*nacosClient.NacosConfigClient, error) {
sc, cc, err := GetNacosConfig(url)
if err != nil {
return nil, err
}
- return nacosClient.NewNacosConfigClient(nacosClientName, true, sc, cc)
+ clientName := url.GetParam(constant.ClientNameKey, "")
Review comment:
我理解应该需要强制抛异常，使用默认又会导致全局只有一个client配置
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
