baerwang commented on a change in pull request #364:
URL: https://github.com/apache/dubbo-go-pixiu/pull/364#discussion_r810559800
##########
File path: pkg/filter/sentinel/config.go
##########
@@ -15,26 +15,15 @@
* limitations under the License.
*/
-package ratelimit
-
-import (
- "github.com/alibaba/sentinel-golang/core/flow"
-)
+package sentinel
const (
- EXACT MatchStrategy = 0
- REGEX MatchStrategy = 1
- ANT_PATH MatchStrategy = 2
+ EXACT MatchStrategy = iota
+ REGEX
+ AntPath
Review comment:
枚举类型的常量就不用带下划线了吧，如果是普通的常量就带下划线
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
