zhaoyunxing92 commented on a change in pull request #1765:
URL: https://github.com/apache/dubbo-go/pull/1765#discussion_r812606389
##########
File path: config/consumer_config.go
##########
@@ -137,24 +137,24 @@ func (cc *ConsumerConfig) Load() {
var count int
for {
checkok := true
- for _, refconfig := range cc.References {
- if (refconfig.Check != nil && *refconfig.Check) ||
- (refconfig.Check == nil && cc.Check) ||
- (refconfig.Check == nil) { // default to true
+ for key, ref := range cc.References {
+ if (ref.Check != nil && *ref.Check &&
GetProviderService(key) == nil) ||
Review comment:
很好的提议，应该去解决check为啥是指针类型的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
