sanxun0325 commented on a change in pull request #364: URL: https://github.com/apache/dubbo-go-pixiu/pull/364#discussion_r815648464
########## File path: pkg/filter/sentinel/circuitbreaker/config.go ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package circuitbreaker + +import "github.com/alibaba/sentinel-golang/core/circuitbreaker" + +type ( + // Resources circuit breaker base config info + Resources struct { Review comment: 这里定义的resources struct 就是sentienl 的Circuitbreaker.Rule ，没必要在这里再定义一遍可以直接引用，像下面的FlowRule一样 ```go // Rule api group 's rate-limit rule Rule struct { ID int64 `json:"id,omitempty" yaml:"id,omitempty"` FlowRule flow.Rule `json:"flowRule,omitempty" yaml:"flowRule,omitempty"` Enable bool `json:"enable,omitempty" yaml:"enable,omitempty"` }` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
