lishangbu commented on a change in pull request #9807:
URL: https://github.com/apache/dubbo/pull/9807#discussion_r830972113
##########
File path:
dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/report/MetadataReportInstance.java
##########
@@ -82,7 +81,7 @@ public void init(List<MetadataReportConfig>
metadataReportConfigs) {
private void init(MetadataReportConfig config, MetadataReportFactory
metadataReportFactory) {
URL url = config.toUrl();
if (METADATA_REPORT_KEY.equals(url.getProtocol())) {
- String protocol = url.getParameter(METADATA_REPORT_KEY,
DEFAULT_DIRECTORY);
+ String protocol = url.getParameter(METADATA_REPORT_KEY,
config.getProtocol());
Review comment:
I agree with you,but metadata report center support
redis/zookeeper/nacos/…….Default value ```dubbo``` will occur a error when
user‘s configuration is empty.
so,I think we need to check the config is empty.it throws exception for user
to remind that they need to config metadata report center protocol correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
