AlexStocks commented on code in PR #1848:
URL: https://github.com/apache/dubbo-go/pull/1848#discussion_r854274760
##########
protocol/dubbo/hessian2/hessian_request.go:
##########
@@ -172,8 +172,9 @@ func packRequest(service Service, header DubboHeader, req
interface{}) ([]byte,
END:
byteArray = encoder.Buffer()
pkgLen = len(byteArray)
- if pkgLen > int(DEFAULT_LEN) { // 8M
- return nil, perrors.Errorf("Data length %d too large, max
payload %d", pkgLen, DEFAULT_LEN)
+ if pkgLen > int(DEFAULT_LEN) { // recommand 8M
+ logger.Warnf("Data length %d too large, recommand max payload
%d. "+
+ "Dubbo java can't handle the package which size greater
than %d!!!", pkgLen, DEFAULT_LEN, DEFAULT_LEN)
Review Comment:
which size greater than = whose size is greater than
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
