zhaoguhong commented on code in PR #9933:
URL: https://github.com/apache/dubbo/pull/9933#discussion_r854849393
##########
dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/integration/RegistryDirectory.java:
##########
@@ -354,8 +356,11 @@ private URL mergeUrl(URL providerUrl) {
providerUrl = providerUrl.addParameter(Constants.CHECK_KEY,
String.valueOf(false)); // Do not check whether the connection is successful or
not, always create Invoker!
+ // fix issue#9922
+ Map<String, String> providerSideParameters = new
HashMap<>(providerUrl.getParameters());
+ providerSideParameters.remove(CommonConstants.TAG_KEY);
// The combination of directoryUrl and override is at the end of
notify, which can't be handled here
- this.overrideDirectoryUrl =
this.overrideDirectoryUrl.addParametersIfAbsent(providerUrl.getParameters());
// Merge the provider side parameters
+ this.overrideDirectoryUrl =
this.overrideDirectoryUrl.addParametersIfAbsent(providerSideParameters); //
Merge the provider side parameters
Review Comment:
`DefaultProviderURLMergeProcessor` only remove consumer side `dubbo.tag`,
provder side `dubbo.tag` still exist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
