Oliverwqcwrw opened a new pull request, #9970:
URL: https://github.com/apache/dubbo/pull/9970
## What is the purpose of the change
> if (export) {
// one channel can have multiple callback instances, no need to
re-export for different instance.
if (!channel.hasAttribute(cacheKey)) {
if (!isInstancesOverLimit(channel, url, clazz.getName(),
instid, false)) {
ModuleModel moduleModel;
if (inv.getServiceModel() == null) {
//TODO should get scope model from url?
moduleModel =
ApplicationModel.defaultModel().getDefaultModule();
logger.error("Unable to get Service Model from
Invocation. Please check if your invocation failed! " +
"This error only happen in UT cases!
Invocation:" + inv);
} else {
moduleModel = inv.getServiceModel().getModuleModel();
}
When boxed type java.lang.Boolean is used as an expression it will throw
NullPointerException if the value is null
## Brief changelog
## Verifying this change
<!-- Follow this checklist to help us incorporate your contribution quickly
and easily: -->
## Checklist
- [x] Make sure there is a
[GitHub_issue](https://github.com/apache/dubbo/issues) field for the change
(usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue,
without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a
little better when cross module dependency exist. If the new feature or
significant change is committed, please remember to add sample in [dubbo
samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to
[dubbo-website](https://github.com/apache/dubbo-website) project if you are
requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation
Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
