106umao commented on code in PR #9978:
URL: https://github.com/apache/dubbo/pull/9978#discussion_r861576904
##########
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/AccessLogFilter.java:
##########
@@ -141,6 +141,7 @@ private void writeLogQueueToFile(String accessLog,
Queue<AccessLogData> logQueue
processWithAccessKeyLogger(logQueue, file);
}
} catch (Exception e) {
+ logQueue.poll();
Review Comment:
> It will be better to modify the traversal method of the queue.
Yes, I think so too, but I'm afraid that changing too much code might not be
acceptable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
