AlexStocks commented on code in PR #1873:
URL: https://github.com/apache/dubbo-go/pull/1873#discussion_r862336855
##########
registry/etcdv3/registry_test.go:
##########
@@ -49,79 +57,103 @@ func initRegistry(t *testing.T) *etcdV3Registry {
return out
}
-//
-//func (suite *RegistryTestSuite) TestRegister() {
-// t := suite.T()
-//
-// url, _ :=
common.NewURL("dubbo://127.0.0.1:20000/com.ikurento.user.UserProvider",
common.WithParamsValue(constant.ClusterKey, "mock"),
common.WithMethods([]string{"GetUser", "AddUser"}))
-//
-// reg := initRegistry(t)
-// err := reg.Register(url)
-// assert.NoError(t, err)
-// children, _, err :=
reg.client.GetChildrenKVList("/dubbo/com.ikurento.user.UserProvider/providers")
-// if err != nil {
-// t.Fatal(err)
-// }
-// assert.Regexp(t,
".*dubbo%3A%2F%2F127.0.0.1%3A20000%2Fcom.ikurento.user.UserProvider%3Fanyhost%3Dtrue%26cluster%3Dmock",
children)
-// assert.NoError(t, err)
-//}
-//
-//func (suite *RegistryTestSuite) TestSubscribe() {
-// t := suite.T()
-// regurl, _ := common.NewURL("registry://127.0.0.1:1111",
common.WithParamsValue(constant.RegistryRoleKey, strconv.Itoa(common.PROVIDER)))
-// url, _ :=
common.NewURL("dubbo://127.0.0.1:20000/com.ikurento.user.UserProvider",
common.WithParamsValue(constant.ClusterKey, "mock"),
common.WithMethods([]string{"GetUser", "AddUser"}))
-//
-// reg := initRegistry(t)
-// // provider register
-// err := reg.Register(url)
-// if err != nil {
-// t.Fatal(err)
-// }
-//
-// // consumer register
-// regurl.SetParam(constant.RegistryRoleKey, strconv.Itoa(common.Consumer))
-// reg2 := initRegistry(t)
-//
-// err = reg2.Register(url)
-// assert.NoError(t, err)
-// listener, err := reg2.DoSubscribe(url)
-// if err != nil {
-// t.Fatal(err)
-// }
-//
-// serviceEvent, err := listener.Next()
-// if err != nil {
-// t.Fatal(err)
-// }
-// assert.Regexp(t, ".*ServiceEvent{Action{add}.*", serviceEvent.String())
-//}
-
-func (suite *RegistryTestSuite) TestConsumerDestroy() {
- t := suite.T()
- url, _ :=
common.NewURL("dubbo://127.0.0.1:20000/com.ikurento.user.UserProvider",
common.WithParamsValue(constant.ClusterKey, "mock"),
common.WithMethods([]string{"GetUser", "AddUser"}))
-
- reg := initRegistry(t)
- _, err := reg.DoSubscribe(url)
- if err != nil {
- t.Fatal(err)
+func Test_etcdV3Registry_DoRegister(t *testing.T) {
+ type fields struct {
+ BaseRegistry registry.BaseRegistry
+ cltLock sync.Mutex
+ client *gxetcd.Client
+ listenerLock sync.RWMutex
+ listener *etcdv3.EventListener
+ dataListener *dataListener
+ configListener *configurationListener
+ }
+ type args struct {
+ root string
+ node string
}
- // listener.Close()
- time.Sleep(1e9)
- reg.Destroy()
+ var client *gxetcd.Client
+ patches := gomonkey.NewPatches()
+ patches = patches.ApplyMethod(reflect.TypeOf(client), "RegisterTemp",
func(_ *gxetcd.Client, k, v string) error {
+ return nil
+ })
+ defer patches.Reset()
- assert.Equal(t, false, reg.IsAvailable())
+ tests := []struct {
+ name string
+ fields fields
+ args args
+ wantErr bool
+ }{
+ {
+ name: "test",
+ fields: fields{
+ client: client,
+ },
+ args: args{
+ root: "/dubbo",
+ node: "/go",
+ },
+ wantErr: false,
+ },
+ }
+ for _, tt := range tests {
+ t.Run(tt.name, func(t *testing.T) {
+ r := &etcdV3Registry{
+ BaseRegistry: tt.fields.BaseRegistry,
+ cltLock: tt.fields.cltLock,
+ client: tt.fields.client,
+ listenerLock: tt.fields.listenerLock,
+ listener: tt.fields.listener,
+ dataListener: tt.fields.dataListener,
+ configListener: tt.fields.configListener,
Review Comment:
如上。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
