AlexStocks commented on code in PR #1898:
URL: https://github.com/apache/dubbo-go/pull/1898#discussion_r875453621
##########
remoting/etcdv3/facade.go:
##########
@@ -46,54 +43,16 @@ type clientFacade interface {
// HandleClientRestart keeps the connection between client and server
func HandleClientRestart(r clientFacade) {
-
- var (
- err error
- failTimes int
- )
-
defer r.WaitGroup().Done()
-LOOP:
for {
select {
case <-r.Done():
logger.Warnf("(ETCDV3ProviderRegistry)reconnectETCDV3
goroutine exit now...")
- break LOOP
+ return
// re-register all services
Review Comment:
这块逻辑是确保一旦etcd集群发送崩溃重启后， etcd client 和 server 重连成功，不能删掉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
