CrazyHZM commented on code in PR #10048:
URL: https://github.com/apache/dubbo/pull/10048#discussion_r877001066
##########
dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/support/AbstractRegistry.java:
##########
@@ -220,16 +221,17 @@ public void doSaveProperties(long version) {
} finally {
lock.release();
}
- }
- } catch (Throwable e) {
- savePropertiesRetryTimes.incrementAndGet();
- if (savePropertiesRetryTimes.get() >=
MAX_RETRY_TIMES_SAVE_PROPERTIES) {
+ } catch (Throwable e) {
if (e instanceof OverlappingFileLockException) {
- // fix #9341, ignore OverlappingFileLockException
logger.info("Failed to save registry cache file for file
overlapping lock exception, file name " + file.getName());
} else {
- logger.warn("Failed to save registry cache file after
retrying " + MAX_RETRY_TIMES_SAVE_PROPERTIES + " times, cause: " +
e.getMessage(), e);
+ throw e;
}
+ }
Review Comment:
`OverlappingFileLockException` still needs to be retried.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
