CoolIceV opened a new issue, #1954:
URL: https://github.com/apache/dubbo-go/issues/1954

   **What happened:**
   When I tested the adaptive service, I found that the cpu load on the 
adaptive service was much higher, I used pprof to analyse it and found that a 
lot of CPU time was spent on the time formatting in the 
`NewHillClimbingUpdater` function.
   
![image](https://user-images.githubusercontent.com/42159666/177469692-4f7d847c-0de7-4c50-820b-7240a3d326b7.png)
   I found that even though `adaptive-service-verbose` is set to false, the 
code still converts the time to a string and passes it to `VerboseDebugf`, 
which is completely unnecessary
   
https://github.com/apache/dubbo-go/blob/b7e348319f82444e18ecda284e20656d7ed3b861/filter/adaptivesvc/limiter/hill_climbing.go#L125-L135
   **What you expected to happen:**
   When `adaptive-service-verbose` is set to false, formatting time is no 
longer executed.
    
   **How to reproduce it (as minimally and precisely as possible):**
   The following is set in conf:
   ```
       adaptive-service: true
       adaptive-service-verbose: false
   ```
   
   **Anything else we need to know?:**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to