CrazyHZM commented on code in PR #10282:
URL: https://github.com/apache/dubbo/pull/10282#discussion_r916427438
##########
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/api/newportunification/NewWireProtocol.java:
##########
@@ -0,0 +1,16 @@
+package org.apache.dubbo.remoting.api.newportunification;
+
+import org.apache.dubbo.common.URL;
+import org.apache.dubbo.common.extension.ExtensionScope;
+import org.apache.dubbo.common.extension.SPI;
+
+@SPI(scope = ExtensionScope.FRAMEWORK)
+public interface NewWireProtocol {
Review Comment:
Do not create new ones, call the original abstract interface
##########
dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyTransporter.java:
##########
@@ -32,7 +33,8 @@ public class NettyTransporter implements Transporter {
@Override
public RemotingServer bind(URL url, ChannelHandler handler) throws
RemotingException {
- return new NettyServer(url, handler);
+// return new NettyServer(url, handler);
+ return new NettyPortUnificationServer(url, handler);
Review Comment:
Do not replace the original logic. `NettyPortUnificationServer` should be
created with `NettyPortUnification Transporter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
