BurningCN commented on code in PR #10308:
URL: https://github.com/apache/dubbo/pull/10308#discussion_r918729022
##########
dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/beans/factory/annotation/ReferenceAnnotationBeanPostProcessor.java:
##########
@@ -486,9 +466,7 @@ public String registerReferenceBean(String propertyName,
Class<?> injectedType,
// see
org.springframework.beans.factory.support.AbstractBeanFactory#getTypeForFactoryBean()
GenericBeanDefinition targetDefinition = new GenericBeanDefinition();
targetDefinition.setBeanClass(interfaceClass);
- String id = getPropertyValue(beanDefinition.getPropertyValues(),
ReferenceAttributes.ID);
Review Comment:
id就是前面的referenceBeanName，没有必要在获取一次
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
