CrazyHZM commented on code in PR #10318:
URL: https://github.com/apache/dubbo/pull/10318#discussion_r921747807
##########
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/exchange/PortUnificationExchanger.java:
##########
@@ -28,20 +31,25 @@
public class PortUnificationExchanger {
private static final Logger log =
LoggerFactory.getLogger(PortUnificationExchanger.class);
- private static final ConcurrentMap<String, PortUnificationServer> servers
= new ConcurrentHashMap<>();
+ private static final ConcurrentMap<String, AbstractPortUnificationServer>
servers = new ConcurrentHashMap<>();
Review Comment:
replace `AbstractPortUnificationServer` with `RemotingServer`
##########
dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyPortUnificationServerHandler.java:
##########
@@ -60,6 +67,7 @@ public void exceptionCaught(ChannelHandlerContext ctx,
Throwable cause) throws E
@Override
public void channelActive(ChannelHandlerContext ctx) throws Exception {
+// NettyChannel ch = NettyChannel.getOrAddChannel(ctx.channel(), url,
handler);
Review Comment:
remove useless code.
##########
dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyPortUnificationServerHandler.java:
##########
@@ -32,21 +36,24 @@
import java.util.List;
import java.util.Set;
-public class PortUnificationServerHandler extends ByteToMessageDecoder {
+public class NettyPortUnificationServerHandler extends ByteToMessageDecoder {
private static final Logger LOGGER = LoggerFactory.getLogger(
- PortUnificationServerHandler.class);
+ NettyPortUnificationServerHandler.class);
private final ChannelGroup channels;
private final SslContext sslCtx;
private final URL url;
+ private final ChannelHandler handler;
private final boolean detectSsl;
private final List<WireProtocol> protocols;
- public PortUnificationServerHandler(URL url, SslContext sslCtx, boolean
detectSsl,
- List<WireProtocol> protocols, ChannelGroup channels) {
+ public NettyPortUnificationServerHandler(URL url, SslContext sslCtx,
boolean detectSsl,
+ List<WireProtocol> protocols,
ChannelGroup channels,
+ ChannelHandler handler) {
this.url = url;
+ this.handler = handler;
Review Comment:
remove useless code.
##########
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/api/AbstractWireProtocol.java:
##########
@@ -16,14 +16,13 @@
*/
package org.apache.dubbo.remoting.api;
-import io.netty.handler.codec.http2.Http2FrameLogger;
+public abstract class AbstractWireProtocol implements WireProtocol {
-import static io.netty.handler.logging.LogLevel.DEBUG;
+ private final ProtocolDetector detector;
-public abstract class Http2WireProtocol implements WireProtocol {
- public static final Http2FrameLogger CLIENT_LOGGER = new
Http2FrameLogger(DEBUG, "H2_CLIENT");
- public static final Http2FrameLogger SERVER_LOGGER = new
Http2FrameLogger(DEBUG, "H2_SERVER");
- private final ProtocolDetector detector = new Http2ProtocolDetector();
+ protected AbstractWireProtocol(ProtocolDetector detector) {
Review Comment:
replace `protected` with `public`
##########
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/api/pu/PortUnificationTransporter.java:
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.remoting.api.pu;
+
+import org.apache.dubbo.common.URL;
+import org.apache.dubbo.common.extension.Adaptive;
+import org.apache.dubbo.common.extension.ExtensionScope;
+import org.apache.dubbo.common.extension.SPI;
+import org.apache.dubbo.remoting.ChannelHandler;
+import org.apache.dubbo.remoting.Client;
+import org.apache.dubbo.remoting.Constants;
+import org.apache.dubbo.remoting.RemotingException;
+
+@SPI(value = "pu_netty", scope = ExtensionScope.FRAMEWORK)
Review Comment:
It can be represented by `netty`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
