JasonKai9527 commented on code in PR #10023:
URL: https://github.com/apache/dubbo/pull/10023#discussion_r922597482
##########
dubbo-rpc/dubbo-rpc-rest/src/main/java/org/apache/dubbo/rpc/protocol/rest/RestProtocol.java:
##########
@@ -136,65 +133,77 @@ protected <T> Runnable doExport(T impl, Class<T> type,
URL url) throws RpcExcept
@Override
protected <T> T doRefer(Class<T> serviceType, URL url) throws RpcException
{
+ ReferenceCountedClient referenceCountedClient =
clients.computeIfAbsent(url.getAddress(), _key -> {
Review Comment:
if the ip:port is the same,but httpclient config properties are different,
how to fix this situation?
i think you should create one object to keep them as the clients cache's
key, at least adress and httpclient configuration should be included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
