djl394922860 commented on code in PR #8954:
URL: https://github.com/apache/dubbo/pull/8954#discussion_r923144878
##########
dubbo-common/src/main/java/org/apache/dubbo/common/timer/HashedWheelTimer.java:
##########
@@ -647,6 +679,26 @@ public void expire() {
return;
}
+ // run timeout task at separate thread to avoid the worker thread
blocking
+ try {
+ if (timer.taskExecutor == null) {
+ // the global executor service should be gotten at each
calling to avoid using invalid executor.
+
GlobalResourcesRepository.getGlobalExecutorService().execute(this);
Review Comment:
> `taskExecutor` must not null ? Whether to consider that are must required ？
Because we need to give the user the right to create thread pools to prevent
creating too many thread pools
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
