jk-tonycui opened a new pull request, #10412: URL: https://github.com/apache/dubbo/pull/10412
## What is the purpose of the change 为了解决issue列表中 https://github.com/apache/dubbo/issues/10402 的问题，该问题主要描述如下： AbstractRegistry.doSaveProperties()虽然采用文件锁、版本号以及重试等方式对竟争场景做了处理，但是在竟争文件锁失败创建重试任务时，没有sleep，仍会有概率出现上一个版本保存操作还没有释放锁，新版本重试次数达到上限导致新版本数据没有保存到cache文件的情况。 ## Brief changelog 改动点主要是将默认共享线程池 SharedExecutor 换成了 SharedScheduleExecutor 以支持增加默认的延迟，避免快速重试导致上述问题出现。 也考虑过通过实现类似Spring-Retry方式实现，但对于现有结构改动较大且收益不高，所以采用 ScheduleExecutor 方式改动 ## Verifying this change <!-- Follow this checklist to help us incorporate your contribution quickly and easily: --> ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
