AlbumenJ commented on code in PR #10414:
URL: https://github.com/apache/dubbo/pull/10414#discussion_r940853533
##########
dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/MemorySafeLinkedBlockingQueue.java:
##########
@@ -69,6 +78,15 @@ public int getMaxFreeMemory() {
return maxFreeMemory;
}
+ /**
+ * set the rejector.
+ *
+ * @param rejector the rejector
+ */
+ public void setRejector(final Rejector<E> rejector) {
+ this.rejector = rejector;
+ }
Review Comment:
How can the user change this field?
##########
dubbo-common/src/main/java/org/apache/dubbo/common/concurrent/Rejector.java:
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dubbo.common.concurrent;
+
+import org.apache.dubbo.common.threadpool.MemorySafeLinkedBlockingQueue;
+
+/**
+ * RejectHandler, it works when you need to custom reject action in {@link
MemorySafeLinkedBlockingQueue}.
+ *
+ * @see AbortPolicy
+ * @see DiscardPolicy
+ * @see DiscardOldestPolicy
+ */
+public interface Rejector<E> {
+
+ /**
+ * Method that may be invoked by a {@link MemorySafeLinkedBlockingQueue}
when {@link MemorySafeLinkedBlockingQueue#hasRemainedMemory}
+ * return true. This may occur when no more memory are available because
their bounds would be exceeded.
+ *
+ * <p>In the absence of other alternatives, the method may throw an
unchecked
+ * {@link RejectException}, which will be propagated to the caller.
+ *
+ * @param e the element requested to be added
+ * @param queue the queue attempting to add this element
+ *
+ * @throws RejectException if there is no more memory
+ */
+ void reject(E e, MemorySafeLinkedBlockingQueue<E> queue);
Review Comment:
I mean it's better to change the signature of this function to `void
reject(E e, Queue<E> queue)`. The `Rejector` here should not be coupled with
actual queue types like `MemorySafeLinkedBlockingQueue`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
