AlbumenJ commented on code in PR #10431:
URL: https://github.com/apache/dubbo/pull/10431#discussion_r942427801


##########
dubbo-filter/dubbo-filter-validation/src/main/java/org/apache/dubbo/validation/support/jvalidation/JValidator.java:
##########
@@ -290,6 +290,8 @@ public void validate(String methodName, Class<?>[] 
parameterTypes, Object[] argu
                 logger.info("Failed to validate service: " + clazz.getName() + 
", method: " + methodName + ", cause: " + violations);
                 throw new ConstraintViolationException("Failed to validate 
service: " + clazz.getName() + ", method: " + methodName + ", cause: " + 
violations, violations);
             }
+        } catch (ConstraintViolationException e) {
+            throw e;

Review Comment:
   `javax.validation.ConstraintViolationException` might have potential 
serialization issue. Should be converted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to