BurningCN commented on code in PR #10508:
URL: https://github.com/apache/dubbo/pull/10508#discussion_r955819199
##########
dubbo-registry/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/client/AbstractServiceDiscovery.java:
##########
@@ -67,29 +67,28 @@ public abstract class AbstractServiceDiscovery implements
ServiceDiscovery {
protected ApplicationModel applicationModel;
public AbstractServiceDiscovery(ApplicationModel applicationModel, URL
registryURL) {
- this(applicationModel.getApplicationName(), registryURL);
- this.applicationModel = applicationModel;
Review Comment:
70行对应构造方法内部使用的`ApplicationModel`为`ApplicationModel.defaultModel()`，而非使用是71行的`ApplicationModel`。从而使得在调用`getCacheNameSuffix()`使用的是`defaultModule`的`appName`。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
