PhilYue commented on code in PR #469: URL: https://github.com/apache/dubbo-go-pixiu/pull/469#discussion_r956715743
########## pkg/wasm/service.go: ########## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package wasm + +import ( + "math" + "os" + "path/filepath" + "sync" + "sync/atomic" +) + +import ( + "github.com/mitchellh/mapstructure" + "mosn.io/proxy-wasm-go-host/common" + "mosn.io/proxy-wasm-go-host/proxywasm" + "mosn.io/proxy-wasm-go-host/wasmer" +) + +import ( + "github.com/apache/dubbo-go-pixiu/pkg/context/http" + "github.com/apache/dubbo-go-pixiu/pkg/model" +) + +// WasmService manages a collection of WasmInstances of the same type. +type WasmService struct { + rootContextID int32 + contextIDGenerator int32 + name string + path string + mutex sync.Mutex + model model.WasmService + instancePool sync.Pool +} + +// WasmConfig contains config about every wasmFile. +type WasmConfig struct { + Path string `yaml:"path" json:"path,omitempty"` +} + +// ABIContextWrapper is a request wrapper which indicates request was handled in the wasmInstance. +type ABIContextWrapper struct { + ContextID int32 + name string + Context *proxywasm.ABIContext +} + +func createWasmService(service model.WasmService) (*WasmService, error) { + var cfg WasmConfig + if err := mapstructure.Decode(service.Config, &cfg); err != nil { + return nil, err + } + + wasmService := &WasmService{ + contextIDGenerator: 0, + name: service.Name, + path: cfg.Path, + mutex: sync.Mutex{}, + model: service, + } + wasmService.rootContextID = atomic.AddInt32(&wasmService.contextIDGenerator, 1) + + wasmService.instancePool = sync.Pool{ + New: func() interface{} { + pwd, _ := os.Getwd() + instance := wasmer.NewWasmerInstanceFromFile(filepath.Join(pwd, cfg.Path)) + proxywasm.RegisterImports(instance) Review Comment: instance 做非空判断，或者提前判断 path 下 wasm 文件是否存在，给出友好 log -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
