wucheng1997 commented on code in PR #10544:
URL: https://github.com/apache/dubbo/pull/10544#discussion_r964649488
##########
dubbo-xds/src/main/java/org/apache/dubbo/registry/xds/util/protocol/AbstractProtocol.java:
##########
@@ -231,6 +234,16 @@ public void onNext(DiscoveryResponse value) {
@Override
public void onError(Throwable t) {
logger.error("xDS Client received error message! detail:", t);
+
+ if (t instanceof StatusRuntimeException) {
+ try {
+ StreamObserver<DiscoveryRequest> requestObserver =
xdsChannel.createDeltaDiscoveryRequest(new ResponseObserver(requestId));
+ requestObserverMap.put(requestId, requestObserver);
Review Comment:
https://github.com/grpc/grpc-java/issues/9522
目前看来这个observer的onError方法是在grpc层实现的,这里是没办法修改,在目前的实现方案,能做的只能是重试,envoy的实现也是new
connection,我修改了一下,看一下这种实现是否合理一些。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]