[GitHub] [dubbo] TrueAbc commented on a diff in pull request #10602: add dubbo protocol to pu server and port reuse

[GitBox]

TrueAbc commented on code in PR #10602:
URL: https://github.com/apache/dubbo/pull/10602#discussion_r969460970


##########
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java:
##########
@@ -580,6 +581,24 @@ private void exportUrl(URL url, List<URL> registryURLs) {
 
             // export to remote if the config is not local (export to local 
only when config is local)
             if (!SCOPE_LOCAL.equalsIgnoreCase(scope)) {
+                // export to extra protocol is used in remote export
+                String extProtocol = url.getParameter("ext.protocol", "");

Review Comment:
   This is a new attribute of ProtocolConfig.java. Can be set in both xml and 
java code. And finally loaded into url object. So we could get this attribute 
here.
   <img width="771" alt="image" 
src="https://user-images.githubusercontent.com/47651330/189880671-7668b372-ee46-4193-957a-6f131859102e.png";>
   <img width="522" alt="image" 
src="https://user-images.githubusercontent.com/47651330/189881572-94afc7f7-bc6a-448c-a538-097e83e711ca.png";>
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org