AlbumenJ commented on code in PR #10793:
URL: https://github.com/apache/dubbo/pull/10793#discussion_r1002708187
##########
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/RpcContext.java:
##########
@@ -63,6 +63,20 @@ protected RpcContextAttachment initialValue() {
}
};
+ private static final InternalThreadLocal<RpcContextAttachment>
CLIENT_RESPONSE_LOCAL = new InternalThreadLocal<RpcContextAttachment>() {
+ @Override
+ protected RpcContextAttachment initialValue() {
+ return new RpcContextAttachment();
+ }
+ };
+
+ private static final InternalThreadLocal<RpcContextAttachment>
SERVER_RESPONSE_LOCAL = new InternalThreadLocal<RpcContextAttachment>() {
+ @Override
+ protected RpcContextAttachment initialValue() {
+ return new RpcContextAttachment();
+ }
+ };
Review Comment:
Remove `SERVER_LOCAL`. Adapt those apis into `CLIENT_RESPONSE_LOCAL` and
`SERVER_RESPONSE_LOCAL`
##########
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/PenetrateAttachmentSelector.java:
##########
@@ -29,6 +29,7 @@ public interface PenetrateAttachmentSelector {
*
* @return attachment pass to next hop
*/
- Map<String, Object> select();
+ Map<String, Object> select(Invocation invocation);
+ Map<String, Object> selectReverse(Invocation invocation);
Review Comment:
Add some desc of this breaking change in
`https://dubbo.apache.org/zh/docs3-v2/java-sdk/upgrades-and-compatibility/`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
