AlbumenJ commented on issue #10765:
URL: https://github.com/apache/dubbo/issues/10765#issuecomment-1299391655

   > 
2、即使调整到`PropertySourcesPlaceholderConfigurer`执行过后,目前`ModuleEnvironment`获取属性的方式将依旧拿不到配置属性,
   > 
   > 
https://github.com/apache/dubbo/blob/bf991e457f6378364ac6ca36f19edce1891d2804/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/context/DubboInfraBeanRegisterPostProcessor.java#L86-L88
   > 
   > 
,因为目前是从Spring的`ConfigurableEnvironment`取值,而`PropertySourcesPlaceholderConfigurer`不会将解析的属性值存储到该对象,而是另外存储在`PropertySources`中。
   
   这个有必要的话是可以调整的
   
   > 另外,还有个疑问需要跟您确认。 如果采用Spring 
3.x之后已经过时的`PropertyPlaceholderConfigurer`来配置的话,就没办法实现Dubbo让特定格式的配置直接生效的功能。因为`PropertyPlaceholderConfigurer`没有对外提供如`PropertySources`之类的属性集合(我从Spring源码没找到,如果有还希望大佬予以指导)。
 所以如果用过时的`PropertyPlaceholderConfigurer`,且没有显式地写`<dubbo:consumer 
tag="${key}">`导致`dubbo.consumer.tag`不能生效,**这种情况应该不需要解决吧?**
   
   这个方式在 `2.7.8` 版本中是支持的,可以看下之前是怎么实现的,这个理论上来说应该只是一个 bugfix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to