marcingrzejszczak commented on PR #11021: URL: https://github.com/apache/dubbo/pull/11021#issuecomment-1327368184
Let me provide an additional explanation. Thanks to this PR, by properly configuring Micrometer Observation (`ObservationRegistry`) with Micrometer Tracing (`Tracer`) and Micrometer Core (`MeterRegistry`) you can have out of the box metrics and tracing support in Apache Dubbo. I've managed to configure that for the Boot samples in core and this is the result in Zipkin   And these are the collected metrics: *Server* ``` ==== METRICS ==== - Metric type [LONG_TASK_TIMER], name [rpc.server.duration.active], tags [tag(net.peer.name=192.168.68.116), tag(net.peer.port=35898), tag(rpc.method=sayHello), tag(rpc.service=org.apache.dubbo.springboot.demo.DemoService), tag(rpc.system=apache_dubbo)], measurements [Measurement{statistic='ACTIVE_TASKS', value=0.0}, Measurement{statistic='DURATION', value=0.0}] - Metric type [TIMER], name [rpc.server.duration], tags [tag(error=none), tag(net.peer.name=192.168.68.116), tag(net.peer.port=35898), tag(rpc.method=sayHello), tag(rpc.service=org.apache.dubbo.springboot.demo.DemoService), tag(rpc.system=apache_dubbo)], measurements [Measurement{statistic='COUNT', value=1.0}, Measurement{statistic='TOTAL_TIME', value=0.022346498}, Measurement{statistic='MAX', value=0.022346498}] ================= ``` *Client* ``` ==== METRICS ==== - Metric type [LONG_TASK_TIMER], name [rpc.client.duration.active], tags [tag(rpc.method=sayHello), tag(rpc.service=org.apache.dubbo.springboot.demo.DemoService), tag(rpc.system=apache_dubbo)], measurements [Measurement{statistic='ACTIVE_TASKS', value=0.0}, Measurement{statistic='DURATION', value=0.0}] - Metric type [TIMER], name [rpc.client.duration], tags [tag(error=none), tag(rpc.method=sayHello), tag(rpc.service=org.apache.dubbo.springboot.demo.DemoService), tag(rpc.system=apache_dubbo)], measurements [Measurement{statistic='COUNT', value=1.0}, Measurement{statistic='TOTAL_TIME', value=0.188515207}, Measurement{statistic='MAX', value=0.188515207}] ================= ``` I did my best to follow the experimental OpenTelemetry semantic conventions for [tracing](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/rpc.md) and [metrics](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/rpc-metrics.md) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
