chickenlj commented on code in PR #11023: URL: https://github.com/apache/dubbo/pull/11023#discussion_r1032522042
########## dubbo-test/dubbo-test-integration/dubbo-integration-provider/pom.xml: ########## @@ -0,0 +1,133 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + --> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.dubbo</groupId> + <artifactId>dubbo-test-integration</artifactId> + <version>${revision}</version> + <relativePath>../pom.xml</relativePath> + </parent> + <artifactId>dubbo-integration-provider</artifactId> + <packaging>jar</packaging> + <name>${project.artifactId}</name> + <description>The integration provider module of dubbo project</description> + <properties> Review Comment: `dubbo-demo` is for users and `dubbo-test` is for maintainers. In this PR,`dubbo-demo` has been tailored for demonstrasting purpose with each module focusing on one use case. For`dubbo-test`, it is ok for us to add some more complicated use cases to validate changes, it's much cheaper for maintainers to verify changes than running from a separate repo. ########## dubbo-test/dubbo-test-integration/dubbo-integration-provider/pom.xml: ########## @@ -0,0 +1,133 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + --> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.dubbo</groupId> + <artifactId>dubbo-test-integration</artifactId> + <version>${revision}</version> + <relativePath>../pom.xml</relativePath> + </parent> + <artifactId>dubbo-integration-provider</artifactId> + <packaging>jar</packaging> + <name>${project.artifactId}</name> + <description>The integration provider module of dubbo project</description> + <properties> Review Comment: `dubbo-demo` is for users while `dubbo-test` is for maintainers. In this PR,`dubbo-demo` has been tailored for demonstrasting purpose with each module focusing on one use case. For`dubbo-test`, it is ok for us to add some more complicated use cases to validate changes, it's much cheaper for maintainers to verify changes than running from a separate repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
