AlbumenJ commented on code in PR #10745: URL: https://github.com/apache/dubbo/pull/10745#discussion_r1033057607
########## dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/loadbalance/AdaptiveLoadBalanceTest.java: ########## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.dubbo.rpc.cluster.loadbalance; + +import org.apache.dubbo.common.URL; +import org.apache.dubbo.rpc.AdaptiveMetrics; +import org.apache.dubbo.rpc.Invoker; +import org.apache.dubbo.rpc.model.ApplicationModel; + +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.MethodOrderer; +import org.junit.jupiter.api.Order; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.TestMethodOrder; + +import java.util.HashMap; +import java.util.Map; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.function.Function; +import java.util.stream.Collectors; + +@TestMethodOrder(MethodOrderer.OrderAnnotation.class) +class AdaptiveLoadBalanceTest extends LoadBalanceBaseTest { + + private ApplicationModel scopeModel; + + private AdaptiveMetrics adaptiveMetrics; + + @Test + @Order(0) + void testSelectByWeight() { + int sumInvoker1 = 0; + int sumInvoker2 = 0; + int sumInvoker3 = 0; + int loop = 10000; + + ApplicationModel scopeModel = ApplicationModel.defaultModel(); + + AdaptiveLoadBalance lb = new AdaptiveLoadBalance(scopeModel); + for (int i = 0; i < loop; i++) { + Invoker selected = lb.select(weightInvokers, null, weightTestInvocation); + + if (selected.getUrl().getProtocol().equals("test1")) { + sumInvoker1++; + } + + if (selected.getUrl().getProtocol().equals("test2")) { + sumInvoker2++; + } + + if (selected.getUrl().getProtocol().equals("test3")) { + sumInvoker3++; + } + } + + // 1 : 9 : 6 + System.out.println(sumInvoker1); + System.out.println(sumInvoker2); + System.out.println(sumInvoker3); + Assertions.assertEquals(sumInvoker1 + sumInvoker2 + sumInvoker3, loop, "select failed!"); + } + + private String buildServiceKey(Invoker invoker){ + URL url = invoker.getUrl(); + return url.getAddress() + ":" + invocation.getProtocolServiceKey(); + } + + private AdaptiveMetrics getAdaptiveMetricsInstance(){ + if (adaptiveMetrics == null) { + adaptiveMetrics = scopeModel.getBeanFactory().getBean(AdaptiveMetrics.class); + } + return adaptiveMetrics; + } + + @Test + @Order(1) + void testSelectByAdaptive() throws NoSuchFieldException, IllegalAccessException { + int sumInvoker1 = 0; + int sumInvoker2 = 0; + int sumInvoker5 = 0; + int loop = 10000; + + scopeModel = ApplicationModel.defaultModel(); + AdaptiveLoadBalance lb = new AdaptiveLoadBalance(scopeModel); + + lb.select(weightInvokersSR, null, weightTestInvocation); + + for (int i = 0; i < loop; i++) { + Invoker selected = lb.select(weightInvokersSR, null, weightTestInvocation); + + Map<String, String> metricsMap = new HashMap<>(); + String idKey = buildServiceKey(selected); + + if (selected.getUrl().getProtocol().equals("test1")) { + sumInvoker1++; + metricsMap.put("rt", "10"); + metricsMap.put("load", "10"); + metricsMap.put("curTime", String.valueOf(System.currentTimeMillis()-10)); + getAdaptiveMetricsInstance().addConsumerSuccess(idKey); + } + + if (selected.getUrl().getProtocol().equals("test2")) { + sumInvoker2++; + metricsMap.put("rt", "100"); + metricsMap.put("load", "40"); + metricsMap.put("curTime", String.valueOf(System.currentTimeMillis()-100)); + getAdaptiveMetricsInstance().addConsumerSuccess(idKey); + } + + if (selected.getUrl().getProtocol().equals("test5")) { + metricsMap.put("rt", "5000"); + metricsMap.put("load", "400");//400% + metricsMap.put("curTime", String.valueOf(System.currentTimeMillis() - 5000)); + + getAdaptiveMetricsInstance().addErrorReq(idKey); + sumInvoker5++; + } + getAdaptiveMetricsInstance().setProviderMetrics(idKey,metricsMap); + + } + Map<Invoker<LoadBalanceBaseTest>, Integer> weightMap = weightInvokersSR.stream() + .collect(Collectors.toMap(Function.identity(), e -> Integer.valueOf(e.getUrl().getParameter("weight")))); + Integer totalWeight = weightMap.values().stream().reduce(0, Integer::sum); + // max deviation = expectWeightValue * 2 + int expectWeightValue = loop / totalWeight; + int maxDeviation = expectWeightValue * 2; + double beta = 0.5; + //这个估算值并不准确 + double ewma1 = beta * 50 + (1 - beta) * 10; + double ewma2 = beta * 50 + (1 - beta) * 100; + double ewma5 = beta * 50 + (1 - beta) * 5000; + + AtomicInteger weight1 = new AtomicInteger(); + AtomicInteger weight2 = new AtomicInteger(); + AtomicInteger weight5 = new AtomicInteger(); + weightMap.forEach((k, v) ->{ + if (k.getUrl().getProtocol().equals("test1")){ + weight1.set(v); + } + else if (k.getUrl().getProtocol().equals("test2")){ + weight2.set(v); + } + else if (k.getUrl().getProtocol().equals("test5")){ + weight5.set(v); + } + }); + + System.out.println(sumInvoker1); + System.out.println(sumInvoker2); + System.out.println(sumInvoker5); Review Comment: Print here is useless ########## dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/loadbalance/AdaptiveLoadBalanceTest.java: ########## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.dubbo.rpc.cluster.loadbalance; + +import org.apache.dubbo.common.URL; +import org.apache.dubbo.rpc.AdaptiveMetrics; +import org.apache.dubbo.rpc.Invoker; +import org.apache.dubbo.rpc.model.ApplicationModel; + +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.MethodOrderer; +import org.junit.jupiter.api.Order; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.TestMethodOrder; + +import java.util.HashMap; +import java.util.Map; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.function.Function; +import java.util.stream.Collectors; + +@TestMethodOrder(MethodOrderer.OrderAnnotation.class) +class AdaptiveLoadBalanceTest extends LoadBalanceBaseTest { + + private ApplicationModel scopeModel; + + private AdaptiveMetrics adaptiveMetrics; + + @Test + @Order(0) + void testSelectByWeight() { + int sumInvoker1 = 0; + int sumInvoker2 = 0; + int sumInvoker3 = 0; + int loop = 10000; + + ApplicationModel scopeModel = ApplicationModel.defaultModel(); + + AdaptiveLoadBalance lb = new AdaptiveLoadBalance(scopeModel); + for (int i = 0; i < loop; i++) { + Invoker selected = lb.select(weightInvokers, null, weightTestInvocation); + + if (selected.getUrl().getProtocol().equals("test1")) { + sumInvoker1++; + } + + if (selected.getUrl().getProtocol().equals("test2")) { + sumInvoker2++; + } + + if (selected.getUrl().getProtocol().equals("test3")) { + sumInvoker3++; + } + } + + // 1 : 9 : 6 + System.out.println(sumInvoker1); + System.out.println(sumInvoker2); + System.out.println(sumInvoker3); + Assertions.assertEquals(sumInvoker1 + sumInvoker2 + sumInvoker3, loop, "select failed!"); + } + + private String buildServiceKey(Invoker invoker){ + URL url = invoker.getUrl(); + return url.getAddress() + ":" + invocation.getProtocolServiceKey(); + } + + private AdaptiveMetrics getAdaptiveMetricsInstance(){ + if (adaptiveMetrics == null) { + adaptiveMetrics = scopeModel.getBeanFactory().getBean(AdaptiveMetrics.class); + } + return adaptiveMetrics; + } + + @Test + @Order(1) + void testSelectByAdaptive() throws NoSuchFieldException, IllegalAccessException { + int sumInvoker1 = 0; + int sumInvoker2 = 0; + int sumInvoker5 = 0; + int loop = 10000; + + scopeModel = ApplicationModel.defaultModel(); + AdaptiveLoadBalance lb = new AdaptiveLoadBalance(scopeModel); + + lb.select(weightInvokersSR, null, weightTestInvocation); + + for (int i = 0; i < loop; i++) { + Invoker selected = lb.select(weightInvokersSR, null, weightTestInvocation); + + Map<String, String> metricsMap = new HashMap<>(); + String idKey = buildServiceKey(selected); + + if (selected.getUrl().getProtocol().equals("test1")) { + sumInvoker1++; + metricsMap.put("rt", "10"); + metricsMap.put("load", "10"); + metricsMap.put("curTime", String.valueOf(System.currentTimeMillis()-10)); + getAdaptiveMetricsInstance().addConsumerSuccess(idKey); + } + + if (selected.getUrl().getProtocol().equals("test2")) { + sumInvoker2++; + metricsMap.put("rt", "100"); + metricsMap.put("load", "40"); + metricsMap.put("curTime", String.valueOf(System.currentTimeMillis()-100)); + getAdaptiveMetricsInstance().addConsumerSuccess(idKey); + } + + if (selected.getUrl().getProtocol().equals("test5")) { + metricsMap.put("rt", "5000"); + metricsMap.put("load", "400");//400% + metricsMap.put("curTime", String.valueOf(System.currentTimeMillis() - 5000)); + + getAdaptiveMetricsInstance().addErrorReq(idKey); + sumInvoker5++; + } + getAdaptiveMetricsInstance().setProviderMetrics(idKey,metricsMap); + + } + Map<Invoker<LoadBalanceBaseTest>, Integer> weightMap = weightInvokersSR.stream() + .collect(Collectors.toMap(Function.identity(), e -> Integer.valueOf(e.getUrl().getParameter("weight")))); + Integer totalWeight = weightMap.values().stream().reduce(0, Integer::sum); + // max deviation = expectWeightValue * 2 + int expectWeightValue = loop / totalWeight; + int maxDeviation = expectWeightValue * 2; + double beta = 0.5; + //这个估算值并不准确 Review Comment: comment in English ########## dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/loadbalance/AdaptiveLoadBalanceTest.java: ########## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.dubbo.rpc.cluster.loadbalance; + +import org.apache.dubbo.common.URL; +import org.apache.dubbo.rpc.AdaptiveMetrics; +import org.apache.dubbo.rpc.Invoker; +import org.apache.dubbo.rpc.model.ApplicationModel; + +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.MethodOrderer; +import org.junit.jupiter.api.Order; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.TestMethodOrder; + +import java.util.HashMap; +import java.util.Map; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.function.Function; +import java.util.stream.Collectors; + +@TestMethodOrder(MethodOrderer.OrderAnnotation.class) +class AdaptiveLoadBalanceTest extends LoadBalanceBaseTest { + + private ApplicationModel scopeModel; + + private AdaptiveMetrics adaptiveMetrics; + + @Test + @Order(0) + void testSelectByWeight() { + int sumInvoker1 = 0; + int sumInvoker2 = 0; + int sumInvoker3 = 0; + int loop = 10000; + + ApplicationModel scopeModel = ApplicationModel.defaultModel(); + + AdaptiveLoadBalance lb = new AdaptiveLoadBalance(scopeModel); + for (int i = 0; i < loop; i++) { + Invoker selected = lb.select(weightInvokers, null, weightTestInvocation); + + if (selected.getUrl().getProtocol().equals("test1")) { + sumInvoker1++; + } + + if (selected.getUrl().getProtocol().equals("test2")) { + sumInvoker2++; + } + + if (selected.getUrl().getProtocol().equals("test3")) { + sumInvoker3++; + } + } + + // 1 : 9 : 6 + System.out.println(sumInvoker1); + System.out.println(sumInvoker2); + System.out.println(sumInvoker3); Review Comment: Print is useless in unit test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
