songjiachao commented on code in PR #323: URL: https://github.com/apache/dubbo-js/pull/323#discussion_r1035839691
########## packages/dubbo-serialization/src/proto.ts: ########## @@ -0,0 +1,64 @@ +import fs from 'fs' +import path from 'path' +import _ from 'lodash' Review Comment: <img width="1015" alt="image" src="https://user-images.githubusercontent.com/70792885/204781787-dcff998a-f6c4-4d72-abcc-a2a8ab4296c4.png";> 这个已经弃用了直接 typeof value === 'string' -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/70792885/204781787-dcff998a-f6c4-4d72-abcc-a2a8ab4296c4.png"](https://user-images.githubusercontent.com/70792885/204781787-dcff998a-f6c4-4d72-abcc-a2a8ab4296c4.png"){kind=link}