XDanwar commented on code in PR #11063:
URL: https://github.com/apache/dubbo/pull/11063#discussion_r1039343901


##########
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/ForkingClusterInvoker.java:
##########
@@ -83,26 +81,29 @@ public Result doInvoke(final Invocation invocation, 
List<Invoker<T>> invokers, L
             }
             RpcContext.getServiceContext().setInvokers((List) selected);
             final AtomicInteger count = new AtomicInteger();
-            final BlockingQueue<Object> ref = new LinkedBlockingQueue<>(1);
-            for (final Invoker<T> invoker : selected) {
+            final CountDownLatch countDownLatch = new CountDownLatch(1);
+            AtomicReference<Object> result = new AtomicReference<>();
+            selected.forEach(invoker -> {

Review Comment:
   need consider  exception case
   n provider  first n-1 exceptions need to be ignored



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

Reply via email to